Reduce buffer allocations #2320
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reosfire
force-pushed
the
reduce-buffer-allocations
branch
from
a506f2f to
3d8dee4
Compare
soywiz
reviewed
May 7, 2025
| //println(data.sizeInBytes) | ||
| // Only check small buffers | ||
| if (data.sizeInBytes < 1024) { | ||
| if (this.mem != null && this.mem!!.sizeInBytes == data.sizeInBytes && arrayequal(this.mem!!, 0, data, 0, data.sizeInBytes)) return this |
Contributor
There was a problem hiding this comment.
Is this part deleted? I guess the point is not being marked as dirty, so it doesn't need to be uploaded to the GPU again.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims at reducing buffer allocations in the AGBuffer.upload methods by copying data directly when the buffer sizes match, instead of always cloning the buffer.
- Refactored overloaded upload functions for various data types to pass a needClone flag.
- Introduced a private upload method that conditionally copies or clones the buffer based on the existing memory size.
| upload(data, needClone = true) | ||
|
|
||
| private fun upload(data: Buffer, needClone: Boolean): AGBuffer { | ||
| if (mem?.sizeInBytes == data.sizeInBytes) { |
There was a problem hiding this comment.
[nitpick] Consider adding a check to compare the content of mem and data for small buffers, as the previous implementation did, to avoid unnecessary copying when the existing buffer already matches the new data.
Contributor
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can just copy data from buffer to buffer instead of making clone when buffers size match.